Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't crash when parsing +. #1865

Merged
merged 2 commits into from
Jan 5, 2023
Merged

Don't crash when parsing +. #1865

merged 2 commits into from
Jan 5, 2023

Conversation

nex3
Copy link
Contributor

@nex3 nex3 commented Jan 5, 2023

@nex3 nex3 requested a review from Goodwine January 5, 2023 00:07
@nex3 nex3 merged commit 14c1634 into main Jan 5, 2023
@nex3 nex3 deleted the plus-dot branch January 5, 2023 01:03
@stof
Copy link
Contributor

stof commented Jan 11, 2023

This fix looks incomplete to me. AFAICT, it will now crash on -1. (and +1.)

@connorskees
Copy link
Contributor

A trailing 0 is optional in dart's stdlib float parsing, and in all float parsers I am aware of.

image

@stof
Copy link
Contributor

stof commented Jan 11, 2023

The issue is not the float parsing. It is the sass parser error that happens when calling _tryDecimal with allowTrailingDot: false

@nex3 nex3 mentioned this pull request Jan 17, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Goodwine Goodwine Goodwine approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Crash on float with leading sign but with no decimal
4 participants
@nex3 @stof @connorskees @Goodwine