Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix :has(+ &) #1938

Merged
merged 1 commit into from
Apr 19, 2023
Merged

Fix :has(+ &) #1938

merged 1 commit into from
Apr 19, 2023

Conversation

nex3
Copy link
Contributor

@nex3 nex3 commented Apr 17, 2023

@nex3 nex3 requested a review from tbondwilkinson April 18, 2023 21:20
tbondwilkinson
tbondwilkinson approved these changes Apr 19, 2023
View reviewed changes
Copy link

@tbondwilkinson tbondwilkinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm assuming that the spec change is the test for this functionality, and there is no dart-sass unit test to update?

@nex3
Copy link
Contributor Author

nex3 commented Apr 19, 2023

Yep, that's right.

@nex3 nex3 merged commit 3091de5 into main Apr 19, 2023
@nex3 nex3 deleted the has-parent branch April 19, 2023 22:29
jgerigmeyer added a commit to oddbird/dart-sass that referenced this pull request Apr 28, 2023
@jgerigmeyer
Merge branch 'main' into browser
8f98cae 
* main:
  Split SilentComment nodes on empty lines in SCSS (sass#1945)
  Fix :has(+ &) (sass#1938)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tbondwilkinson tbondwilkinson tbondwilkinson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Broken :has with modifier compilation
2 participants
@nex3 @tbondwilkinson