Include pubspec.lock, for reproducible builds #1948
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 tasks
12 tasks
|
Because Dart Sass is distributed as a Dart library as well as a binary release, it's expected to work with all compatible version constellations of its dependencies. We don't include a lockfile because it can lead to us accidentally testing on only those specific package versions, even though our users will potentially be using different versions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm requesting this to lower the burden on package maintainers from having individual copies of this file.
This may also help pervent issue caused by accidental API changes on dependencies.
Looking at the git history it seems like the decision to ignore pubspec.lock was simply inherited from a template gitignore, since the first commit cf28c7e.