-
Notifications
You must be signed in to change notification settings - Fork 351
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Calc functions implementation #1970
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In your PR description, add a link to the corresponding sass-spec
PR. That way the CI pipeline will run the tests against your other PR rather than HEAD
E.g. add:
Tests: https://github.com/sass/sass-spec/pull/1912
The format is not important IIRC, as long as you have a link to the PR it should work.
ce38d29
to
68b60a3
Compare
68b60a3
to
e3e91d7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the CI errors are complaining because you must generate the "synchronized" file. The async_evaluate.dart
file has a non-async counterpart (eveluate.dart
) that is autogenerated.
You can run dart run grinder synchronize
to generate it. Then you can add it to this PR
e3e91d7
to
78f593e
Compare
f86fc49
to
a0eace6
Compare
4373794
to
885dfc7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work so far, round
involves a supporting a tricky set of different behaviors, so my most substantial comments are on it.
acfdde9
to
b9b9602
Compare
12fbaa4
to
6f963c4
Compare
6f963c4
to
8fdd53e
Compare
510ee08
to
b1625bd
Compare
5048f83
to
9f3341e
Compare
9f3341e
to
49088f0
Compare
pubspec.yaml
Outdated
@@ -1,5 +1,5 @@ | |||
name: sass | |||
version: 1.64.3 | |||
version: 1.65.0-dev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can release this now, please change the version to 1.65.0
without -dev
. And then, modify the following 2 files:
pkg/sass_api/pubspec.yaml
- Update the Sass version to
sass: 1.65.0
- Update the package version to
version: 8.1.0
- Update the Sass version to
pkg/sass_api/CHANGELOG.md
- Add a new entry for version
8.1.0
saying "No user-visible changes.", you can see other examples of this if you scroll down in the same file.
- Add a new entry for version
49088f0
to
16ca999
Compare
16ca999
to
9b1558a
Compare
Context: Calc functions proposal
Tests: sass/sass-spec#1912