Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add current stylesheet to loadedUrls when throwing parsing error #1991

Merged
merged 3 commits into from
Jun 9, 2023
Merged

Add current stylesheet to loadedUrls when throwing parsing error #1991

merged 3 commits into from
Jun 9, 2023

Conversation

ntkme
Copy link
Contributor

@ntkme ntkme commented Jun 7, 2023

This PR fixes the bug where the loadedUrls on Exception would be empty when throwing a parsing error on root stylesheet:

sass.compileString(`a { `, { url: new URL('file:///a.scss' ) });

The root cause is that root stylesheet parsing error is thrown by Stylesheet.parse before the evaluation starts in _compileStylesheet.

@nex3 nex3 merged commit 760fa2e into sass:main Jun 9, 2023
@ntkme ntkme deleted the loadedurls-for-parsing-error branch June 9, 2023 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants