Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run cli compilations in parallel dart isolates #2078

Merged
merged 9 commits into from
Sep 9, 2023
Merged

Run cli compilations in parallel dart isolates #2078

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
e4063fd
Run cli compilations in parallel dart isolates
ntkme Sep 2, 2023
18040c0
Code review
ntkme Sep 7, 2023
e74352d
Code review
ntkme Sep 7, 2023
9ad9407
Code review
ntkme Sep 7, 2023
6808a7d
Code review
ntkme Sep 7, 2023
e95080e
Remove unnecessary imports
ntkme Sep 7, 2023
938010a
Style/organization cleanup
nex3 Sep 8, 2023
0fe6dc0
Make print thread safe
ntkme Sep 8, 2023
9e0a682
Rename to safePrint
ntkme Sep 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
18 changes: 17 additions & 1 deletion lib/src/io/vm.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,8 +37,24 @@ bool get supportsAnsiEscapes {
return io.stdout.supportsAnsiEscapes;
}

void print(Object? message) {
ntkme marked this conversation as resolved.
Show resolved Hide resolved
_threadSafeWriteLn(io.stdout, message);
}

void printError(Object? message) {
io.stderr.writeln(message);
_threadSafeWriteLn(io.stderr, message);
}

void _threadSafeWriteLn(io.IOSink sink, Object? message) {
// For better performance the buffer is mutated.
if (message is StringBuffer) {
message.writeln();
sink.write(message);
ntkme marked this conversation as resolved.
Show resolved Hide resolved
} else {
var buffer = StringBuffer(message.toString());
buffer.writeln();
sink.write(buffer);
}
}

String readFile(String path) {
Expand Down