Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the version of Sass used by the website on release #2102

Merged
merged 2 commits into from
Sep 30, 2023
Merged

Update the version of Sass used by the website on release #2102

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
70fcba5
Update the version of Sass used by the website on release
nex3 Sep 28, 2023
f73a3c3
Fully install Sass
nex3 Sep 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -597,6 +597,18 @@ jobs:
repository: sass/sass-site
token: ${{ secrets.SASS_SITE_TOKEN }}

- name: Get version
id: version
run: echo "version=${GITHUB_REF##*/}" | tee --append "$GITHUB_OUTPUT"

- name: Update Dart Sass version
run: |
cat package.json |
jq --arg version ^${{ steps.version.outputs.version }} '
.devDependencies.sass |= $version
' > package.json.tmp
mv package.json.tmp package.json
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As there is a committed lock file, this won't be enough

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can run npm update sass after that, which should update only sass in the package-lock.json.

However, this job should depends on deploy_npm so that it's updated only after npm package has been published.


- uses: EndBug/add-and-commit@v9
with:
author_name: Sass Bot
Expand Down