Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Escape non-US-ASCII characters in SassException.toCssString() #2143

Merged
merged 3 commits into from
Dec 8, 2023
Merged

Escape non-US-ASCII characters in SassException.toCssString() #2143

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
86eb2f1
Escape non-US-ASCII characters in `SassException.toCssString()`
ntkme Dec 6, 2023
b2f34ce
Update changelog
nex3 Dec 8, 2023
b1935a1
Merge branch 'main' into us-ascii
nex3 Dec 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,10 @@
* Produce better output for numbers with complex units in `meta.inspect()` and
debugging messages.

* When generating CSS error messages to display in-browser, escape all code
points that aren't in the US-ASCII region. Previously only code points U+0100
LATIN CAPITAL LETTER A WITH MACRON were escaped.

### JS API

* Fix a bug where certain exceptions could produce `SourceSpan`s that didn't
Expand Down
4 changes: 2 additions & 2 deletions lib/src/exception.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,12 +82,12 @@ class SassException extends SourceSpanException {
.replaceAll("\r\n", "\n");
term_glyph.ascii = wasAscii;

// For the string comment, render all non-ASCII characters as escape
// For the string comment, render all non-US-ASCII characters as escape
// sequences so that they'll show up even if the HTTP headers are set
// incorrectly.
var stringMessage = StringBuffer();
for (var rune in SassString(toString(color: false)).toString().runes) {
if (rune > 0xFF) {
if (rune > 0x7F) {
stringMessage
..writeCharCode($backslash)
..write(rune.toRadixString(16))
Expand Down