Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check require.main for null before getting require.main.filename #2179

Closed
wants to merge 2 commits into from
Closed

Check require.main for null before getting require.main.filename #2179

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
abf0f4a
Check require.main for null before getting require.main.filename
jamesnw Feb 18, 2024
8cdc6dc
Eval rmf when needed
jamesnw Feb 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/src/js/compile.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -336,8 +336,8 @@ final JSClass nodePackageImporterClass = () {
'sass.NodePackageImporter',
(Object self, [String? entryPointDirectory]) => NodePackageImporter(
entryPointDirectory ??
(requireMainFilename != null
? p.dirname(requireMainFilename!)
(requireMainFilename() != null
? p.dirname(requireMainFilename()!)
: null)));
return jsClass;
}();
17 changes: 15 additions & 2 deletions lib/src/js/utils.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -234,6 +234,19 @@ Syntax parseSyntax(String? syntax) => switch (syntax) {
_ => jsThrow(JsError('Unknown syntax "$syntax".'))
};

/// The value of require.main.filename
/// The value of require.main
@JS("require.main")
external Object? get _requireMain;

/// The value of require.main.filename. require.main is not defined when the
/// entry point is not a CommonJS module, so this throws if require.main is
/// null.
@JS("require.main.filename")
external String? get requireMainFilename;
external String? get _unsafeRequireMainFilename;

/// The value of require.main.filename, or null if require.main or
/// require.main.filename are null.
String? requireMainFilename() =>
_requireMain != null && _unsafeRequireMainFilename != null
? _unsafeRequireMainFilename
: null;