-
Notifications
You must be signed in to change notification settings - Fork 351
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate deprecations list from the language repo #2253
Merged
Merged
Changes from 7 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
ce65b4e
Generate deprecations list from the language repo
jathak 22e3741
Update changelogs and bump versions
jathak 73d89ce
Make sure to actually generate the deprecations on the CI
jathak 67e575e
Avoid importing Sass AST into grinder
jathak 585727e
Synchronize
jathak c87ecce
Check-in generated deprecations list
jathak d377bd0
Don't build deperecations in CI
jathak db0e4fc
Eliminate template by just generating a block
jathak 3cfc2a6
Fix indentation
jathak File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,7 @@ | ||
## 10.4.3 | ||
|
||
* No user-visible changes. | ||
|
||
## 10.4.2 | ||
|
||
* No user-visible changes. | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -7,11 +7,13 @@ | |
import 'dart:io'; | ||
import 'dart:convert'; | ||
|
||
import 'package:crypto/crypto.dart'; | ||
import 'package:path/path.dart' as p; | ||
import 'package:pub_semver/pub_semver.dart'; | ||
import 'package:pubspec_parse/pubspec_parse.dart'; | ||
import 'package:test/test.dart'; | ||
|
||
import '../tool/grind/generate_deprecations.dart' as deprecations; | ||
import '../tool/grind/synchronize.dart' as synchronize; | ||
|
||
/// Tests that double-check that everything in the repo looks sensible. | ||
|
@@ -22,7 +24,7 @@ void main() { | |
if (File(targetPath).readAsStringSync() != | ||
synchronize.synchronizeFile(sourcePath)) { | ||
fail("$targetPath is out-of-date.\n" | ||
"Run `dart pub run grinder` to update it."); | ||
"Run `dart run grinder` to update it."); | ||
} | ||
}); | ||
}); | ||
|
@@ -31,6 +33,16 @@ void main() { | |
// newline normalization issues. | ||
testOn: "!windows"); | ||
|
||
test("deprecations are up-to-date", () { | ||
var inputText = File(deprecations.yamlPath).readAsStringSync(); | ||
var outputText = File(deprecations.dartPath).readAsStringSync(); | ||
var checksum = sha1.convert(utf8.encode(inputText)); | ||
if (!outputText.contains('// Checksum: $checksum')) { | ||
fail('${deprecations.dartPath} is out-of-date.\n' | ||
'Run `dart run grinder` to update it.'); | ||
} | ||
}, testOn: "!windows"); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Probably worth including the above comment here as well, or moving this condition onto a group that contains both up-to-date tests. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Done |
||
|
||
for (var package in [ | ||
".", | ||
...Directory("pkg").listSync().map((entry) => entry.path) | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: missing indentation