Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use pubspec_parse for dependency equality #2254

Merged
merged 1 commit into from
May 29, 2024
Merged

Use pubspec_parse for dependency equality #2254

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ dev_dependencies:
lints: ">=2.0.0 <5.0.0"
protoc_plugin: ">=20.0.0 <22.0.0"
pub_api_client: ^2.1.1
pubspec_parse: ^1.0.0
pubspec_parse: ^1.3.0
test: ^1.16.7
test_descriptor: ^2.0.0
test_process: ^2.0.0
Expand Down
10 changes: 2 additions & 8 deletions test/double_check_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,14 +116,8 @@ void main() {
});

test("matches dartdoc version", () {
// TODO(nweiz): Just use equals() once dart-lang/pubspec_parse#127 lands
// and is released.
var sassDep = sassPubspec.devDependencies["dartdoc"];
var pkgDep = pkgPubspec.devDependencies["dartdoc"];
expect(pkgDep, isA<HostedDependency>());
expect(sassDep, isA<HostedDependency>());
expect((pkgDep as HostedDependency).version,
equals((sassDep as HostedDependency).version));
expect(sassPubspec.devDependencies["dartdoc"],
equals(pkgPubspec.devDependencies["dartdoc"]));
});
});
}
Expand Down