Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix windows-arm64 release #2274

Merged
merged 2 commits into from
Jul 10, 2024
Merged

Fix windows-arm64 release #2274

merged 2 commits into from
Jul 10, 2024

Conversation

ntkme
Copy link
Contributor

@ntkme ntkme commented Jul 9, 2024

@nex3
Copy link
Contributor

nex3 commented Jul 9, 2024

Can you add a comment here indicating that we can't use the shared workflow and linking to the GitHub discussion?

@ntkme
Copy link
Contributor Author

ntkme commented Jul 9, 2024

https://github.com/sass/dart-sass/actions/workflows/build-windows.yml

@nex3 By the way, there should be a "run workflow" button on page the linked above. After we merge this PR, you can use the "run workflow" button to test it out, that it will build the windows artifacts without an actual release. I cannot personally try it as I do not have access to see the button, so it would be very helpful if you can trigger a run after merging to see if there is any other issue or not.

@nex3 nex3 merged commit c96b5e2 into sass:main Jul 10, 2024
34 checks passed
@ntkme ntkme deleted the windows-arm64 branch July 11, 2024 00:06
@ntkme
Copy link
Contributor Author

ntkme commented Jul 11, 2024

It looks like dart-sdk on windows 11 for arm might be missing CA certs like this issue: dart-lang/pub#1882

@ntkme
Copy link
Contributor Author

ntkme commented Jul 11, 2024

@nex3 Can we try change the command to dart pub get --verbose so that we can see what exactly failed?

@nex3
Copy link
Contributor

nex3 commented Jul 11, 2024

Rerunning with --verbose now.

@nex3
Copy link
Contributor

nex3 commented Jul 11, 2024

Here's the result, although I'm not sure how much more information it gives us. I think it may be better at this point to just resurrect #2275 to get releases back on track.

@ntkme
Copy link
Contributor Author

ntkme commented Jul 11, 2024

FINE: Wrapped exception: HandshakeException: Handshake error in client (OS Error: 
    | 	CERTIFICATE_VERIFY_FAILED: unable to get local issuer certificate(../../third_party/boringssl/src/ssl/handshake.cc:393))

It looks indeed like missing ca certs. I think unable to get local issuer means unable to get parent certificate for the server certificate. This parent is either an intermediate certificate (usually served by server) or a root ca (need to be trusted locally).

So most likely there is an issue with the default root CA config.

@ntkme
Copy link
Contributor Author

ntkme commented Jul 11, 2024

@nex3 If you want to do #2275, you have to just switch the runner to windows-latest to build a kernel snapshot. Disabling it will cause release failure in embedded-host-node.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants