Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add documentation link to legacy-js-api warning #2355

Merged
merged 2 commits into from
Sep 19, 2024
Merged

Add documentation link to legacy-js-api warning #2355

merged 2 commits into from
Sep 19, 2024

Conversation

jathak
Copy link
Member

@jathak jathak commented Sep 19, 2024

No description provided.

@jathak jathak requested a review from nex3 September 19, 2024 22:24
nex3
nex3 approved these changes Sep 19, 2024
View reviewed changes
Copy link
Contributor

@nex3 nex3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you'll also need to remove -dev from the pkg/ versions.

@jathak jathak merged commit fa4827f into main Sep 19, 2024
38 checks passed
@jathak jathak deleted the legacy-js-api-documentation branch September 19, 2024 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nex3 nex3 nex3 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jathak @nex3