Fix source map URLs for the legacy API #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If an importer was passed, these URLs were broken by our end-of-load import injection. This fixes the issue by explicitly passing a `sourceMapUrl` field which allows the wrapper to reconstruct the correct URLs. See webpack-contrib/sass-loader#774 (comment)
jathak
approved these changes
Feb 17, 2022
nex3
added a commit
to sass/dart-sass
that referenced
this pull request
Feb 17, 2022
This was referenced Mar 11, 2022
This was referenced Mar 18, 2022
Closed
This was referenced Mar 28, 2022
This was referenced Apr 21, 2022
This was referenced Apr 26, 2022
This was referenced May 4, 2022
This was referenced May 17, 2022
This was referenced Jun 5, 2022
This was referenced Jun 10, 2022
This was referenced Jun 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an importer was passed, these URLs were broken by our end-of-load
import injection. This fixes the issue by explicitly passing a
sourceMapUrlfield which allows the wrapper to reconstruct thecorrect URLs.
See webpack-contrib/sass-loader#774 (comment)
See sass/sass-spec#1776