Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed exports paths in package.json #231

Merged
merged 1 commit into from
Jun 21, 2023
Merged

Fixed exports paths in package.json #231

merged 1 commit into from
Jun 21, 2023

Conversation

BCaspari
Copy link
Contributor

@BCaspari BCaspari commented Jun 21, 2023

Fixed exports paths in package.json - they have to start with ./ according to https://nodejs.org/api/packages.html#exports

The current paths break the build when using sass-loader with sass-embedded and webpack 5.86.0:
[webpack-cli] Error [ERR_INVALID_PACKAGE_TARGET]: Invalid "exports" main target "dist/lib/index.js" defined in the package config /home/runner/.../node_modules/sass-embedded/package.json; targets must start with "./"

Closes #233

Fixed exports paths in package.json - they have to start with ./ according to https://nodejs.org/api/packages.html#exports

The current paths break the build when using sass-loader with sass-embedded and webpack 5.86.0:

[webpack-cli] Error [ERR_INVALID_PACKAGE_TARGET]: Invalid "exports" main target "dist/lib/index.js" defined in the package config /home/runner/work/ProcessHub/ProcessHub/app/node_modules/sass-embedded/package.json; targets must start with "./"
@BCaspari BCaspari changed the title Update package.json Fixed exports paths in package.json Jun 21, 2023
@nex3 nex3 self-requested a review June 21, 2023 19:56
@nex3 nex3 merged commit 35dafed into sass:main Jun 21, 2023
16 checks passed
nex3 added a commit to sass/dart-sass that referenced this pull request Jun 21, 2023
This allows us to release sass/embedded-host-node#231.
nex3 added a commit to sass/dart-sass that referenced this pull request Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Field export must start with ./
2 participants