Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update protocol-version to 2.2.0 #249

Closed
wants to merge 1 commit into from
Closed

Update protocol-version to 2.2.0 #249

wants to merge 1 commit into from

Conversation

ntkme
Copy link
Contributor

@ntkme ntkme commented Sep 26, 2023

The 1.68.0 release failed due to mismatched protocol-version. This PR fixes that.

On the other hand, I wonder if we should automatically update the protocol-version in package.json as part of the dart-sass release process when GitHub Action commits to this repo.

@nex3
Copy link
Contributor

nex3 commented Sep 26, 2023

On the other hand, I wonder if we should automatically update the protocol-version in package.json as part of the dart-sass release process when GitHub Action commits to this repo.

Yes, I think this is the best approach. Otherwise I will definitely forget this every time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants