-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement access tracking for containingUrl #285
Conversation
7e7a586
to
ea4cbd8
Compare
Looks like yesterday's node 20.12.2 is breaking our test on windows: nodejs/node@69ffc6d50d |
@nex3 I added a commit to fix the node regression. Regarding CVE-2024-27980:
|
Can you pull the CVE fix into a separate PR? |
lib/src/importer-registry.ts
Outdated
* it's not part of the package's public API and should not be accessed by | ||
* user code. It may be renamed or removed without warning in the future. | ||
*/ | ||
containingUrlAccessed = false; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make this field private and give it a public getter, so it's clear that only this class should ever modify it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated. I also made the same change for ArugmentList, which is where I copied the pattern.
sass/sass#3835
sass/dart-sass#2220