This repository has been archived by the owner on May 18, 2023. It is now read-only.
Use varints rather than uint32s to delimit messages #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Uint32 limits message sizes to 4.3 gigabytes, which is very large but not outside the range of possibility for CSS output. Partially addresses #37
|
cc @johnfairh |
nex3
added a commit
to sass/dart-sass-embedded
that referenced
this pull request
Dec 22, 2020
nex3
added a commit
to sass/dart-sass-embedded
that referenced
this pull request
Dec 22, 2020
nex3
added a commit
to sass/dart-sass-embedded
that referenced
this pull request
Dec 22, 2020
nex3
added a commit
to sass/dart-sass-embedded
that referenced
this pull request
Dec 22, 2020
nex3
added a commit
to sass/embedded-host-node
that referenced
this pull request
Dec 22, 2020
Awjin
approved these changes
Dec 22, 2020
nex3
added a commit
to sass/dart-sass-embedded
that referenced
this pull request
Dec 23, 2020
nex3
added a commit
to sass/embedded-host-node
that referenced
this pull request
Dec 30, 2020
nex3
added a commit
to sass/embedded-host-node
that referenced
this pull request
Dec 30, 2020
Delimit messages using varints, as per sass/embedded-protocol#38
joshpeterson30489
added a commit
to joshpeterson30489/embedded-dart-sass-development
that referenced
this pull request
Sep 30, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uint32 limits message sizes to 4.3 gigabytes, which is very large but
not outside the range of possibility for CSS output.
Partially addresses #37