Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@debug intentionally sometimes produces different output that the css #1240

Closed
xzyfer opened this issue May 27, 2015 · 3 comments
Closed

@debug intentionally sometimes produces different output that the css #1240

xzyfer opened this issue May 27, 2015 · 3 comments

Comments

@xzyfer
Copy link
Contributor

xzyfer commented May 27, 2015

We need to refactor some internals for this.

$var: 1;
$list: 2, 3;
$new-list: append($var, $list);
$nested-list: $var $list;
@debug($var);
@debug($list);
@debug($new-list);
@debug($nested-list);
div {
 a: $var;
 a: $list;
 a: $new-list;
 a: $nested-list;
}

Ruby Sass

test.scss:31 DEBUG: 1
test.scss:32 DEBUG: 2, 3
test.scss:33 DEBUG: 1 (2, 3)
test.scss:34 DEBUG: 1 (2, 3)
div {
  a: 1;
  a: 2, 3;
  a: 1 2, 3;
  a: 1 2, 3; }

Libsass

test.scss:30: DEBUG: 1
test.scss:31: DEBUG: 2, 3
test.scss:32: DEBUG: 1 (2, 3)
test.scss:33: DEBUG: 1 (2, 3)
div {
  a: 1;
  a: 2, 3;
  a: 1 (2, 3);
  a: 1 (2, 3); }
@xzyfer
Copy link
Contributor Author

xzyfer commented May 31, 2015

Related #1246

@xzyfer xzyfer removed the Dev - WIP label May 31, 2015
@xzyfer xzyfer removed this from the 3.2.5 milestone May 31, 2015
@mgreter mgreter modified the milestones: 3.3, 3.2.6, 3.3.1 Jun 13, 2015
@mgreter mgreter modified the milestones: 3.3.1, 3.3 Jun 13, 2015
@mgreter
Copy link
Contributor

mgreter commented Jun 13, 2015

The DEBUG output is not correct, but the spec test only tests the actual output. Rescoping to 3.3.1.

@mgreter
Copy link
Contributor

mgreter commented Jul 13, 2015

We now have a passing spec test since #1249 was merged 🎈

@mgreter mgreter closed this as completed Jul 13, 2015
@mgreter mgreter modified the milestones: 3.3, 3.3.1 Sep 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants