Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Space after function call followed by variable should not be mandatory #1333

Closed
asyrk opened this issue Jul 10, 2015 · 4 comments
Closed

Space after function call followed by variable should not be mandatory #1333

asyrk opened this issue Jul 10, 2015 · 4 comments

Comments

@asyrk
Copy link

asyrk commented Jul 10, 2015

Related: #733

Input:

$important: ' !important';

@function getColor() {
    @return black;
}

@mixin black() {
    color: getColor()#{$important};
    color: getColor() #{$important};
}

.black-color {
    @include black();
}

Expected output:

.black-color {
    color: black !important;
    color: black  !important;
}

Actual output:

.black-color {
    color: getColor !important;
    color: black  !important;
}
@xzyfer
Copy link
Contributor

xzyfer commented Jul 13, 2015

Thanks @Frexus I can confirm this is still an issue.

xzyfer added a commit to xzyfer/sass-spec that referenced this issue Jul 13, 2015
@xzyfer
Copy link
Contributor

xzyfer commented Jul 13, 2015

Spec added sass/sass-spec#444

@xzyfer xzyfer added this to the 3.3 milestone Jul 13, 2015
@xzyfer xzyfer added the BLOCKED label Jul 13, 2015
@xzyfer
Copy link
Contributor

xzyfer commented Jul 13, 2015

Blocked #1249.

@mgreter
Copy link
Contributor

mgreter commented Jul 14, 2015

This is partially fixed by #1330 ... but quoted strings get inserted unquoted.

@mgreter mgreter modified the milestones: 3.3.1, 3.3 Jul 14, 2015
@xzyfer xzyfer removed the BLOCKED label Jul 14, 2015
mgreter added a commit to mgreter/libsass that referenced this issue Jul 15, 2015
@mgreter mgreter modified the milestones: 3.3, 3.3.1 Jul 16, 2015
@mgreter mgreter self-assigned this Jul 16, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants