Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throw an error on cross-media @extends #1562

Closed
xzyfer opened this issue Sep 21, 2015 · 0 comments · Fixed by #1593
Closed

Throw an error on cross-media @extends #1562

xzyfer opened this issue Sep 21, 2015 · 0 comments · Fixed by #1593

Comments

@xzyfer
Copy link
Contributor

xzyfer commented Sep 21, 2015

Originally reported in #712 and fixed in 3.2.0. This has since regressed.

.foo {
  content: 'foo'; }

@media print {
  .bar {
    @extend .foo; } }

Expected

You may not @extend an outer selector from within @media.
You may only @extend selectors within the same directive.
From "@extend .foo" on line 7.

Result

.foo, .bar {
  content: 'foo'; }

Spec added sass/sass-spec#538

@xzyfer xzyfer added this to the 3.3 milestone Sep 21, 2015
@xzyfer xzyfer modified the milestone: 3.3 Sep 29, 2015
@xzyfer xzyfer self-assigned this Oct 11, 2015
xzyfer added a commit to xzyfer/libsass that referenced this issue Oct 11, 2015
This PR fixes a regression is allowing `@extend`ing across media
queries. Still needs a bit of work.

Regressed in 9f5ef6d
Fixes sass#1562
Spec sass/sass-spec#538
xzyfer added a commit to xzyfer/libsass that referenced this issue Oct 11, 2015
This PR fixes a regression is allowing `@extend`ing across media
queries. Still needs a bit of work.

Regressed in 9f5ef6d
Fixes sass#1562
Spec sass/sass-spec#538
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant