Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

invalid quotes around "normal" line-height in font shorthand property #1570

Closed
mahtd opened this issue Sep 23, 2015 · 5 comments
Closed

invalid quotes around "normal" line-height in font shorthand property #1570

mahtd opened this issue Sep 23, 2015 · 5 comments

Comments

@mahtd
Copy link

mahtd commented Sep 23, 2015

This is a regression in 3.3.0 beta from 3.2.5

Specifying font: <font-size>/<line-height> <font-family> works fine, but adding of the other properties to the font shorthand results in quotes around the line-height when the normal keyword is used. This is considered invalid by the browser (at least in Chrome and Firefox) and property is ignored.

Input:

a {
    font: 12px/normal serif;
}

b {
    font: normal 12px/normal serif;
}

Output libsass 3.2.5:

a {
  font: 12px/normal serif; }

b {
  font: normal 12px/normal serif; }

Output libsass 3.3.0-beta2:

a {
  font: 12px/normal serif; }

b {
  font: normal 12px/"normal" serif; }
@saper
Copy link
Member

saper commented Sep 23, 2015

Testcase added with sass/sass-spec#512

@mahtd
Copy link
Author

mahtd commented Sep 24, 2015

Looks like 06ad34e is the one that broke it

@xzyfer
Copy link
Contributor

xzyfer commented Sep 27, 2015

I cannot reproduce on 997c86d

xzyfer added a commit to xzyfer/sass-spec that referenced this issue Sep 27, 2015
@xzyfer
Copy link
Contributor

xzyfer commented Sep 27, 2015

My mistake.

@xzyfer xzyfer added this to the 3.3 milestone Sep 27, 2015
@xzyfer xzyfer self-assigned this Sep 29, 2015
@xzyfer
Copy link
Contributor

xzyfer commented Sep 29, 2015

I have a fix for this. Will publish when I'm home.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants