Interpolation shouldn't be allowed in IE filters outside of argument list

[andrew-skybound]

Three parsing discrepancies to report here, all related to parsing of IE filter values. These are probably trivial (especially the last two) but I figured I might as well report them anyway.

First, Ruby SASS does not permit interpolation to be used in progid: values outside of the argument list. For example this is not allowed:

test {
  filter: progid:DXImageTransform.Microsoft.#{Alpha(opacity=20)};
}

Ruby SASS:

Error: Invalid CSS after "  filter: progid": expected ";", was ":DXImageTransfo..."

Libsass:

test {
  filter: progid:DXImageTransform.Microsoft.Alpha(opacity=20);
}

Second, Ruby SASS does not allow CSS escapes in progid: values either:

test {
  filter: progid:DXImageTransform.\Microsoft.Alpha(opacity=20);
}

Ruby SASS:

Error: Invalid CSS after "  filter: progid": expected ";", was ":DXImageTransfo..."

Libsass:

test {
  filter: progid:DXImageTransform.\Microsoft.Alpha(opacity=20);
}

Finally, it looks like Ruby treats escaped braces in the argument list as ordinary braces for the purpose of determining where the progid: value ends; Libsass does not:

test {
  filter: progid:DXImageTransform.Microsoft.Alpha(opacity=20\);
}

Ruby SASS:

test {
  filter: progid:DXImageTransform.Microsoft.Alpha(opacity=20\);
}

Libsass:

Error: unclosed parenthesis

If you add an unescaped brace to the end, Ruby SASS fails, and Libsass works, but it does not output the second brace.

test {
  filter: progid:DXImageTransform.Microsoft.Alpha(opacity=20\));
}

Ruby SASS:

Error: Invalid CSS after "...ha(opacity=20\)": expected ";", was ");"

Libsass:

test {
  filter: progid:DXImageTransform.Microsoft.Alpha(opacity=20\);
}

[xzyfer]

Thanks for the @andrew-skybound

[saper]

( Partially related to #1684, #1734 )

[mgreter]

Is this fixed? I wonder because the spec test seems to be active (I get a fail in #1736). But strange enough CI for master seems ok even if I restart it. I also get this problem locally!?

[mgreter]

IMO this should be closed since no longer relevant (last IE version to support filters was IE9). IMO there is no merit to support this in future version of libsass. Feel free to re-open if you see it otherwise. //CC @xzyfer.

[xzyfer]

Agree. On 12 Jan. 2018 9:56 am, "Marcel Greter" <notifications@github.com> wrote: IMO this should be closed since no longer relevant (last IE version to support filters was IE9). IMO there is no merit to support this in future version of libsass. Feel free to re-open if you see it otherwise. //CC @xzyfer <https://github.com/xzyfer>. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1694 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAjZWMyP-G3LRSejL4wCSakntooMVQbTks5tJpGUgaJpZM4GbEgB> .