Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect handling of "\a" escape sequences in interpolations. #1786

Closed
andrew-skybound opened this issue Dec 11, 2015 · 3 comments
Closed

Comments

@andrew-skybound
Copy link

andrew-skybound commented Dec 11, 2015

Here are some fun whitespace bugs for you on your Friday night gentlemen.

Input:

$input: "\0_\a_\A";

test {
    bug1: "#{"_\a" + b}";
    bug2: "#{a $input}";
}

Ruby SASS 3.4.18:

@charset "UTF-8";
test {
  bug1: "_\a b";
  bug2: "a �_ _ ";
}

Libsass 3.3.2-32-gb2a3:

@charset "UTF-8";
test {
  bug1: "_\ab";
  bug2: "a �_\a_\a";
}
@xzyfer xzyfer added this to the 3.4 milestone Dec 27, 2015
xzyfer added a commit to xzyfer/sass-spec that referenced this issue Dec 27, 2015
@xzyfer
Copy link
Contributor

xzyfer commented Dec 27, 2015

Thanks for the report @andrew-skybound.

Spec added sass/sass-spec#647

@mgreter
Copy link
Contributor

mgreter commented Jan 13, 2016

Pretty sure this has something to do that \a is interpreted as \x0A which is \r.

@mgreter
Copy link
Contributor

mgreter commented Jan 18, 2016

I think the main bug is fixed with #1880.
But there is another strange one which I fail to see the logic:

test {
    test-1: "#{'\a'}";
    test-1: "#{x '\a'}";
    test-1: "#{x + '\a'}";
}

Ruby sass:

test {
  test-1: "\a";
  test-1: "x  ";
  test-1: "x\a"; }

Libsass

test {
  test-1: "\a";
  test-1: "x \a";
  test-1: "x\a"; }

Might be a ruby sass bug ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants