Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libsass compilation fails on Visual Studio 2017 #2627

Closed
Nimce opened this issue Apr 7, 2018 · 4 comments
Closed

libsass compilation fails on Visual Studio 2017 #2627

Nimce opened this issue Apr 7, 2018 · 4 comments

Comments

@Nimce
Copy link

Nimce commented Apr 7, 2018

Trying to compile libsass on Visual Studio 2017 on Windows fails with error(s):

operation.hpp(191): error C2027: use of undefined type 'Sass::Selector_List'
operation.hpp(191): error C2027: use of undefined type 'Sass::Complex_Selector'
...

(Errors are repeating themselves, just with different classes).

I'm not very familiar with the code, but changing typeid to use x instead of *x:

throw std::runtime_error(msg + typeid(*x).name());

to:

throw std::runtime_error(msg + typeid(x).name());

Allows libsass to compile successfully.

@mgreter
Copy link
Contributor

mgreter commented Apr 12, 2018

I compiled it just now with MSVC 2017 and can't reproduce, the change is definitely not dangerous, since it only affects error reporting if CRTP implementation is missing some types. But as I said, can't reproduce ...

@idontusenumbers
Copy link

I get the same build errors and can confirm the change @Nimce reports does in fact let the build complete on my machine.

@Ziggizag
Copy link

Ziggizag commented Aug 7, 2018

I also confirm these build errors and confirm the remedy provided by @Nimce works perfectly. I could compile entire sassc.exe using this tip.

@jgroot82
Copy link

Hi I can also confirm that @Nimce solution fix the issue for me.

glebm added a commit to glebm/libsass that referenced this issue Nov 22, 2018
@xzyfer xzyfer closed this as completed in 534065c Nov 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants