Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

comparable() arguments have the wrong names #2916

Closed
nex3 opened this issue Jun 19, 2019 · 0 comments · Fixed by #2946
Closed

comparable() arguments have the wrong names #2916

nex3 opened this issue Jun 19, 2019 · 0 comments · Fixed by #2946
Labels
Compatibility - P3 Minorly important for compatibility with the Sass spec and ecosystem

Comments

@nex3
Copy link
Contributor

nex3 commented Jun 19, 2019

LibSass's comparable() function has argument names $number-1 and $number-2. To match Dart Sass and be consistent with other built-in functions, they should be $number1 and $number2.
@nex3 nex3 added the Compatibility - P3 Minorly important for compatibility with the Sass spec and ecosystem label Jun 19, 2019
nschonni added a commit to nschonni/libsass that referenced this issue Jul 17, 2019
@nschonni
fix: Update comparable signiture
d71d41b 
See sass/sass-spec#1440
Closes sass#2916
@nschonni nschonni mentioned this issue Jul 17, 2019
Merged
nschonni added a commit to nschonni/libsass that referenced this issue Jul 18, 2019
@nschonni
fix: Update comparable signiture
5ac3b7d 
See sass/sass-spec#1440
Closes sass#2916
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Compatibility - P3 Minorly important for compatibility with the Sass spec and ecosystem
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Update comparable signiture nschonni/libsass
1 participant
@nex3