-
Notifications
You must be signed in to change notification settings - Fork 464
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HEAD] - endless loop, working with 3.6.1 #2994
Comments
Thanks @futureweb, this seems to be an issue of the ported dart sass code:
Can you try it with dart sass too and see what you get? Thanks! |
@mgreter tested with dart-sass 1.23.0 and snippet compiles without problems scss source:
Result of dart-sass:
|
@futureweb any chance you can try it with dart-sass master from github directly? |
@mgreter - just tested it with latest dart-sass master - same result as with 1.23.0 --> working |
OK, thanks, will try again when I'm home. Not sure why I get an error in dart sass. |
alright - just drop me a line if you need further tests from me! ;-) |
The issue is in |
And the culprit is the duplicate |
Can you try to patch - selectorStack.emplace_back(evaled);
+ selectorStack.emplace_back(SASS_MEMORY_COPY(evaled)); This seems to fix the issue for me. But need to check further |
@mgreter - I would ... if I could find it?!? |
Sorry, seems I was referencing my latest refactoring branch. It makes your case pass, but fails two circular extend spec tests. Looks like this is more complicated than expected :( |
haha - was already puzzled what you are refering to ... ;-) |
Fixed by #2995 |
sorry for late reply - have overlooked your comment :-/ |
With current libsass HEAD (b894c52) the compiler won't finish, no Error, just endless waiting for SCSS Snippet further down ....
SCSS is from a Templatemonster Template ... got some Templates with compiling Problems with latest HEAD while there were no problems with 3.6.1.
I isolated the Problem to this Part:
SCSS:
Actual results
[libsass HEAD - b894c52]
endless loop without Error
version info:
Expected result
libsass 3.6.1 (4d229af)
CSS:
version info:
Verified with https://www.sassmeister.com/ that it's also compiling with 3.5.4
STRACE of endless processing:
The text was updated successfully, but these errors were encountered: