-
Notifications
You must be signed in to change notification settings - Fork 464
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extending placeholders within media queries silently fails #317
Comments
👍 This issue affects me as well. |
The output of this test in the latest version is:
Rather than:
While this is still incorrect, it's perhaps slightly better. It looks like some work still needs to be done to properly resolve this. |
Definitely still an error. |
mpowroznik
added a commit
to mpowroznik/stitch-css
that referenced
this issue
Oct 11, 2014
Brutal temporary solution. More details: sass/libsass#317 http://thesassway.com/intermediate/understanding-placeholder-selectors#limitations
mpowroznik
added a commit
to mpowroznik/stitch-css
that referenced
this issue
Oct 11, 2014
Brutal temporary solution. More details: sass/libsass#317 http://thesassway.com/intermediate/understanding-placeholder-selectors#limitations
Please fix this. |
@mgreter since you've confirmed this is fixed is there an existing spec to cover this case? |
This is also error related!
|
Yep, my bad! |
mgreter
added a commit
to mgreter/sass-spec
that referenced
this issue
Apr 22, 2016
mgreter
added a commit
to mgreter/sass-spec
that referenced
this issue
Apr 22, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Abstract
Extending a placeholder selector from within a media query in Sass 3.4.9 produces an error, but in Libsass 3.1.0 it produces undesirable output and does not fail.
Details
Given the following SCSS:
Expected
Sass 3.4.9 produces an error
Actual
In Libsass 3.1.0 the output is:
This is obviously very undesirable. Libsass should either throw a syntax error or output no content.
edit updated Jan 5th, 2015
The text was updated successfully, but these errors were encountered: