-
Notifications
You must be signed in to change notification settings - Fork 464
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deep @extend specificity problems #592
Comments
BTW, what's interesting here is that if I just change .a .d.b {
color: green; } i.e. the same what libsass does. Weird. EDIT: I submitted an issue to Ruby Sass about that: sass/sass#1495 |
I'll wait with submitting a PR to sass-spec until the Ruby Sass issue clarifies on what should really be happening. |
As Sass maintainer indicated in sass/sass#1495 (comment), Sass is correct here due to pseudo-element low specificity. This is confirmed to be a libsass bug then. I'll submit a spec. |
Spec submitted: sass/sass-spec#115 |
This, BTW, is more serious than my other recent issues as it can change semantics in some cases. I wonder if a similar spec but with a class instead of a pseudo-selector shouldn't be added to show the difference between those two that libsass doesn't currently respect? This is AFAIK one of the three issues that currently prevent our quite a large Sass code base from migrating to libsass (other two being Great job! |
Fixes sass#592 Tried to implement specificity as per spec, but this turned out not to work like ruby sass. Once I tweaked the specificity constant of all types, it started to work, but I don't know why ruby sass does it that way!
Fixes sass#592 Tried to implement specificity as per spec, but this turned out not to work like ruby sass. Once I tweaked the specificity constant of all types, it started to work, but I don't know why ruby sass does it that way!
This is directly related to #823 |
Looks like this made it into 3.2.0. Updated the milestone. |
The following SCSS input:
is compiled via Ruby Sass (3.4.5) to:
and via libsass (using node-sass 1.1.4) to:
The text was updated successfully, but these errors were encountered: