Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

It does not error when a property-value is missing #945

Closed
am11 opened this issue Mar 14, 2015 · 5 comments · Fixed by #957
Closed

It does not error when a property-value is missing #945

am11 opened this issue Mar 14, 2015 · 5 comments · Fixed by #957

Comments

@am11
Copy link
Contributor

am11 commented Mar 14, 2015

Test http://sassmeister.com/gist/3e38a9c489a9627ffa9d:

.a {
  b:c;
  d:
}
//  see^ even the markdown notifies that something is wrong! (8 

libsass 3.1.0 and libsass 3.2.0-beta.1 (tested locally) output:

.a {
  b: c; }

ruby-sass 3.4.12 errors:

Invalid CSS after "  d:": expected expression (e.g. 1px, bold), was "}"
@xzyfer
Copy link
Contributor

xzyfer commented Mar 15, 2015

Interesting looks like there is no spec that covers this.
On 15 Mar 2015 02:20, "Adeel Mujahid" notifications@github.com wrote:

Test http://sassmeister.com/gist/3e38a9c489a9627ffa9d:

.a {
b:c;
d:
}// see^ even the markdown notifies that something is wrong! (8

libsass 3.2.0-beta.1 outputs:

.a {
b: c; }

ruby-sass 3.4.12 errors:

Invalid CSS after " d:": expected expression (e.g. 1px, bold), was "}"


Reply to this email directly or view it on GitHub
#945.

@am11
Copy link
Contributor Author

am11 commented Mar 15, 2015

Yes! I noticed. But yet again, it could be ignored because it is the error spec..? I have the commit ready for it, but since we are not accepting the PR for spec-repo for errors yet, so should I dare trying? :)

@xzyfer
Copy link
Contributor

xzyfer commented Mar 16, 2015

Spec added sass/sass-spec#276

@xzyfer
Copy link
Contributor

xzyfer commented Mar 16, 2015

Yeah we don't trap specs, but it's nice to have those spec around so we have an idea of how important feature it is. Also there's work happening to re-do sass-spec so having these issues open is good for feature completeness.

@mgreter
Copy link
Contributor

mgreter commented Mar 16, 2015

Actually we parse something ... an empty list 😄

Block 0x29b5680 0
 Ruleset 0x21e77a0 0
  Selector_List 0x2332e90 [block:0x29b5680] [root] [@media:0] - - -
   Complex_Selector 0x21e76e0 [block:0x29b5680] [root] [@media:0] - - - -> { } <> X < >
    Compound_Selector 0x22dfcd0 [block:0x29b5680] [root] [@media:0] - - - <> X < >
     Selector_Reference 0x285efa0 @ref 0
   -Complex_Selector 0x21e7620 [block:0x29b5680] [root] [@media:0] - - - -> { } <> X <>
   - Compound_Selector 0x22dfbd0 [block:0x29b5680] [root] [@media:0] - - - <> X <>
   -  Type_Selector 0x285f100 <<foo>> - <> X < >
  Declaration 0x2dbf1d0 0
   prop: String_Quoted : 0x285f1b0 [bar] <> X <>
   value: List 0x2dbf100Space  [delayed: 0]  [interpolant: 0]

BTW. it is returned explicitly empty from parse_comma_list ...

mgreter added a commit to mgreter/libsass that referenced this issue Mar 16, 2015
@mgreter mgreter self-assigned this Mar 16, 2015
mgreter added a commit to mgreter/libsass that referenced this issue Mar 17, 2015
mgreter added a commit to mgreter/libsass that referenced this issue Mar 17, 2015
@mgreter mgreter added this to the 3.2 milestone Mar 18, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants