Fixing current build issues on Windows 64 bits with MSVC 12/2013 #1423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Something is very appealing about this PR...! |
|
I have submitted sass/sassc#129 to apply the same to sassc (which is used also when building libsass on win32) |
|
This is great @driekus77! I wonder how we can make AppVeyor pick these issues up for us? |
xzyfer
added a commit
that referenced
this pull request
Aug 4, 2015
Fixing current build issues on Windows 64 bits with MSVC 12/2013
This was referenced Aug 4, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hopefully I did everything right this time ;-)
Checkout out current libsass did resolve in build errors and warnings. I did my best to fix them and the result is this PR.
Only build on Win x64 so other builds have to be checked. I will do this if Appveyor results in errors.
Kind regards,
Henry