Fix sass function bug with restargs and nested arglists #1529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgreter
force-pushed
the
bugfix/restargs-and-nested-arglist
branch
from
98cb399
to
1d46370
Compare
|
I can confirm that with this change, the output is consistent with Ruby-Sass output for the issue described in #1171. However, the out-of-range error message from R-Sass reads like:
While LibSass says:
|
|
Errors have never been exactly like ruby sass. I only lately added a similar error reporting than ruby sass, so I guess this error just hasn't been upgraded, or did it say anything else before!? |
mgreter
added a commit
that referenced
this pull request
Sep 4, 2015
Fix sass function bug with restargs and nested arglists
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1171