Hotfix for interpolation adding additional escapes #1534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Added another small commit that fixes #1271 |
|
And another commit added that fixes #1231 |
|
Nice on @mgreter |
xzyfer
added a commit
that referenced
this pull request
Sep 6, 2015
…terpolate Fix regression for interpolation adding additional escapes
This was referenced Sep 6, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes one of the last urgent issues with interpolations. I have tried to solve it multiple times but I fail to see any other logic than implemented here (look ahead if we expect the final string to be a quoted string or not). With this patch we pass these additional spec tests: