Refactor/milestore 3.4 #1841
Merged
Refactor/milestore 3.4 #1841
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgreter
force-pushed
the
refactor/milestore-3.4
branch
2 times, most recently
from
b4a5d01 to
7ea7f1f
Compare
|
We got 💚 against ruby sass master (upcoming 3.4.21) |
mgreter
force-pushed
the
refactor/milestore-3.4
branch
from
03caffc to
7825fff
Compare
Closed
mgreter
force-pushed
the
refactor/milestore-3.4
branch
2 times, most recently
from
450d902 to
7a49730
Compare
|
Rebased branch and renuked latest sass-specs PR ... |
|
There's really no way I can do a meaning review on a PR this big :( Do what you need to do I guess. |
- omit last delimiter semicolon in compressed mode - shorten floats with leading zero in compressed mode
Probably needs some further code clean ups.
Starting point to improve and refactor interpolations and binary expressions to the correct implementations.x
Ruby sass often uses inspect for error reporting etc. We do have a inspect CRTP visitor class, but it requires a valid context which is not always available. At some point we should consolidate those two implementations.
Throw native C++ errors inside value operations Fix delayed binary evaluations (with interpolations)
Also fixes a bunch of little internal issues
mgreter
force-pushed
the
refactor/milestore-3.4
branch
from
7a49730 to
6d4f9a2
Compare
mgreter
added a commit
that referenced
this pull request
Jan 13, 2016
Refactor in preparation for 3.4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should pass sass/sass-spec#669
@xzyfer I'm pushing this here, since I had to fix some stuff in parser for the binary expression handling and could no longer wait. I consider the code base of this branch stable, but its need some more cleaning up. I'm also pretty sure that a few flags and ifs are no longer needed with this refactor.
Beside the fixes that are open in the other PRs, this mainly improves and fixes how we parse values and value schemas. I also added a pretty extensive test suite for this. It passes all expected tests against 3.4.21, minus the open sass bugs, plus the new extended test suite.