Implement missing error checks #1848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgreter
force-pushed
the
bugfix/import-errors
branch
from
0e9279c
to
85e1316
Compare
mgreter
force-pushed
the
bugfix/import-errors
branch
from
85e1316
to
5a7abc3
Compare
mgreter
force-pushed
the
bugfix/import-errors
branch
from
db20ea1
to
19b24a7
Compare
mgreter
changed the title
|
Will merge this as soon as ci is 💚 If any of these error checks regress we can still just uncomment them. I hope we have gathered enough specs to cover pretty much all cases, although I'm not to sure about At_Root and Media_Blocks. But it should also be quite easy to adjust the conditions, since we now can query the parent scope type in parser. I also added a few of my own spec tests to cover the main use cases I could come up with. |
mgreter
added a commit
that referenced
this pull request
Jan 11, 2016
Implement missing error checks
|
Spec for #1670 activated in sass/sass-spec#684 |
|
Spec for #1675 activated in sass/sass-spec#685 |
|
Spec for #871 activated in sass/sass-spec#686 |
|
Remaining spec for #1653 activated in sass/sass-spec#687 |
|
Spec for #1550 activated in sass/sass-spec#688 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should pass specs sass/sass-spec#680
One minor issue not on par with ruby sass, but that will change once we switch sass specs to 3.4.20.