Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle signed char when considering @charset #1914

Merged
merged 1 commit into from
Feb 9, 2016
Merged

Handle signed char when considering @charset #1914

merged 1 commit into from
Feb 9, 2016

Conversation

asottile
Copy link
Member

@asottile asottile commented Feb 9, 2016

Resolves sass/libsass-python#117

On platforms where char is unsigned the @charset (or UTF-8 BOM) was not present in the output. This seems to fix it.

@xzyfer
Copy link
Contributor

xzyfer commented Feb 9, 2016

LGTM.

@xzyfer xzyfer added this to the 3.3.4 milestone Feb 9, 2016
xzyfer added a commit that referenced this pull request Feb 9, 2016
@xzyfer xzyfer merged commit 3054e97 into sass:master Feb 9, 2016
@xzyfer
Copy link
Contributor

xzyfer commented Feb 9, 2016

This is potentially related to #1891

@asottile asottile deleted the fix_charset_unsigned_char branch February 9, 2016 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some tests failing on pp64el, arm64 and s390x
2 participants