Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guard know code paths in error handling #2025

Merged
merged 1 commit into from
Apr 22, 2016

Conversation

mgreter
Copy link
Contributor

@mgreter mgreter commented Apr 21, 2016

Silently drop error json when we cannot generate it due to internal problems.
Improves reported error message by a lot (#2016)

Error: Invalid CSS after "...pecific grammar": expected expression (e.g. 1px, bold), was ". And this thing he"
        on line 1 of foo.scss
>> _((Classes and IDs must follow a specific grammar. And this thing here doesn\x{fffd}t

Improves reported error message by a lot
@coveralls
Copy link

Coverage Status

Coverage remained the same at 78.766% when pulling 9cb6a20 on mgreter:feature/guard-json-stringify into 445ad3c on sass:master.

@mgreter mgreter merged commit 527f3a8 into sass:master Apr 22, 2016
@mgreter mgreter added this to the 3.3.6 milestone Apr 23, 2016
@mgreter mgreter self-assigned this Apr 23, 2016
@asottile
Copy link
Member

Haven't found anything concrete yet, but this commit seems to (somehow?) contribute to a stack overrun: sass/libsass-python#149 (comment)

Hopefully I'll have more information soon :)

@tony
Copy link
Contributor

tony commented Apr 24, 2016

^ Yup apparently its only on Python 3.5 64bit.

https://ci.appveyor.com/project/dahlia/libsass-python/build/322

edit: 3.5 is the only 3.x 64bit being tested on libsass-python atm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants