Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix extending inner of wrapped selectors (unwrap) #2032

Merged
merged 1 commit into from
Apr 23, 2016

Conversation

mgreter
Copy link
Contributor

@mgreter mgreter commented Apr 22, 2016

Fixes #2031

sample

:not(.asd, .qwe) {
  content: list;
}
:not(.foo) {
  content: test;
}
.bar, .baz {
  @extend .foo;
}
test {
  content: selector-extend(":not():not(.foo)", ".foo", ".bar");
}

now yields:

:not(.asd):not(.qwe) {
  content: list; }
:not(.foo):not(.bar):not(.baz) {
  content: test; }
test {
  content: :not:not(.foo):not(.bar); }

ruby sass:

:not(.asd, .qwe) {
  content: list; }
:not(.foo):not(.bar):not(.baz) {
  content: test; }
test {
  content: :not:not(.foo):not(.bar); }

So there is one breaking change from :not(.asd, .qwe) to :not(.asd):not(.qwe). The first is invalid css so I do not mind shipping this in 3.3.6. I think ruby sass should do it either the same way or produce an error as it does in other situations when it tries to print invalid css syntax.

@mgreter mgreter self-assigned this Apr 22, 2016
@mgreter mgreter added this to the 3.3.6 milestone Apr 22, 2016
@coveralls
Copy link

Coverage Status

Coverage increased (+0.009%) to 78.807% when pulling 6172695 on mgreter:bugfix/issue_2031 into 7889f8c on sass:master.

@nicovalencia
Copy link

Thanks! 👍

@bschaf
Copy link

bschaf commented Apr 22, 2016

👍 Thank you!

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.006%) to 79.236% when pulling 4796e00 on mgreter:bugfix/issue_2031 into 57fbfb9 on sass:master.

@xzyfer
Copy link
Contributor

xzyfer commented Apr 23, 2016

@mgreter any objections to releasing 3.3.6 after this is merged?

@mgreter
Copy link
Contributor Author

mgreter commented Apr 23, 2016

@xzyfer yes one, #2001 should also be ready, there was only one issue with MSVC that I already fixed locally. Waiting for CI to catch up.

@xzyfer
Copy link
Contributor

xzyfer commented Apr 23, 2016

@mgreter once these land I'll make sure major projects like foundation, and sassdash still compile as expected.

@mgreter
Copy link
Contributor Author

mgreter commented Apr 23, 2016

@xzyfer just to make sure, you are aware of the "breaking" change here? sass/sass#2036. Reminds me I need to split the spec test I created.

@xzyfer
Copy link
Contributor

xzyfer commented Apr 23, 2016

I wasn't aware, thanks for the link.

@mgreter mgreter merged commit 78a6a77 into sass:master Apr 23, 2016
tony added a commit to tony/libsass-python that referenced this pull request Apr 24, 2016
This fixes a segfault that happens while compiling materializecss.
Its tested with https://github.com/torchbox/django-libsass

The bug is documented on the libsass website at
sass/libsass#1960

The patch was merge upstream at
sass/libsass#2032.
tony added a commit to tony/libsass-python that referenced this pull request Apr 24, 2016
This fixes a segfault that happens while compiling materializecss.
Its tested with https://github.com/torchbox/django-libsass

The bug is documented on the libsass website at
sass/libsass#1960

The patch was merge upstream at
sass/libsass#2032.
tony added a commit to tony/libsass-python that referenced this pull request Apr 24, 2016
This fixes a segfault that happens while compiling materializecss.
Its tested with https://github.com/torchbox/django-libsass

The bug is documented on the libsass website at
sass/libsass#1960

The patch was merge upstream at
sass/libsass#2032.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants