Fix issue with parent selector evaluation #2292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgreter
force-pushed
the
bugfix/issue-2291
branch
from
a871799 to
db75db8
Compare
mgreter
force-pushed
the
bugfix/issue-2291
branch
from
2ea9234 to
2c2353e
Compare
|
Back ported the bug fix to 3.4.4. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This took me quite a few hours to figure out. In the end the fix is rather small, but it seems to be exactly the one needed. It looks like this was previousely "wrongly" fixed here: #2004 (that probably introduced this regression).