Prevent compiler warning about unnecessary copy #3129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This compiler warning comes up a lot, and is due to the unnecessary copy introduced by accidentally using const value instead of const ref here.
cpsievert
added a commit
to rstudio/sass
that referenced
this pull request
Jan 11, 2023
Closes #122 by way of sass/libsass#3129
This was referenced Jan 11, 2023
cpsievert
added a commit
to rstudio/sass
that referenced
this pull request
Jan 12, 2023
* Upgrade libsass from 3.6.4 to 3.6.5 Closes #122 by way of sass/libsass#3129 * Update news
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This compiler warning comes up a lot, and is due to the unnecessary copy introduced by accidentally using const value instead of const ref here.