Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SourceMap: Fix relative paths for Windows (#242) #441

Merged
merged 2 commits into from
Jul 28, 2014
Merged

SourceMap: Fix relative paths for Windows (#242) #441

merged 2 commits into from
Jul 28, 2014

Conversation

am11
Copy link
Contributor

@am11 am11 commented Jul 12, 2014

Fixes #242. (ef00e62)

It required converting all paths to lower-case,
the rest of the implementation was there.
This lower-casing is not locale-aware, as NTFS is
all case-sensitive when it goes beyond ASCII.


Fixes output file's default value (bbc02f3)

When the caller provides the input file path but
misses the output path, the default output should
be input-path-without-extension plus .css.
Case in hand is node-sass, which is currently
missing output file binding (values captured from
--option/-o switches) in their binding.cpp.
Will fix that issue subsequently.
/cc @andrew, @nschonni.

am11 added 2 commits July 13, 2014 04:53
It required converting all paths to lower-case,
the rest of the implementation was there.
This lower-casing is not locale-aware, as NTFS is
all case-sensitive when it goes beyond ASCII.
akhleung pushed a commit that referenced this pull request Jul 28, 2014
SourceMap: Fix relative paths for Windows (#242)
@akhleung akhleung merged commit 61edd14 into sass:master Jul 28, 2014
@am11 am11 deleted the issue-242 branch July 28, 2014 20:17
@am11
Copy link
Contributor Author

am11 commented Jul 28, 2014

Thanks for merging this @akhleung. 👍

@mgreter
Copy link
Contributor

mgreter commented Jul 29, 2014

I have a regression with this merge on windows.

libsass\file.cpp: In function 'std::string Sass::File::resolve_relative_path(const string&, const string&, const string&, bool)':
libsass\file.cpp:91:71: error: no matching function for call to 'transform(std::basic_string<char>::const_iterator, std::basic_string<char>::const_iterator, std::basic_string<char>::iterator, <unresolved overloaded function type>)'

See the <unresolved overloaded function type>.
Problem is explained here: http://stackoverflow.com/questions/1679245

The fix is pretty easy. Just change tolower to ::tolower.

@am11
Copy link
Contributor Author

am11 commented Jul 29, 2014

Oh I see. Actually I first put it then removed the scope resolver. I was just trying to make code look smarter which VC2013's compiler didn't mind. :)

Will fix it. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SourceMap - Producing invalid JSON
3 participants