Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for nth with maps #647

Merged
merged 1 commit into from
Nov 14, 2014
Merged

Add support for nth with maps #647

merged 1 commit into from
Nov 14, 2014

Conversation

xzyfer
Copy link
Contributor

@xzyfer xzyfer commented Nov 14, 2014

This PR add support for nth with maps.

This can return the nth pair in a map as well. - http://sass-lang.com/documentation/Sass/Script/Functions.html#nth-instance_method

Fixes #643. Specs added sass/sass-spec#134.

xzyfer added a commit that referenced this pull request Nov 14, 2014
Add support for nth with maps
@xzyfer xzyfer merged commit 6a548bf into sass:master Nov 14, 2014
@xzyfer xzyfer modified the milestone: 3.0.3 Dec 9, 2014
@xzyfer xzyfer modified the milestones: 3.0.3, 3.1 Dec 22, 2014
@mgreter
Copy link
Contributor

mgreter commented Oct 14, 2015

FYI: I get a success for this test with #1600 ??

@xzyfer
Copy link
Contributor Author

xzyfer commented Oct 15, 2015

@mgreter I'm not sure what you mean.

@xzyfer xzyfer deleted the feat/nth-maps branch October 15, 2015 08:15
@mgreter
Copy link
Contributor

mgreter commented Oct 15, 2015

I got a positive result with my test runner with that branch!
Wondering why now or put different, why did it not pass before?

@xzyfer
Copy link
Contributor Author

xzyfer commented Oct 15, 2015

I'm confused because the spec should have always passed. I'm not following
what your PR has to do with this old feature.
On 15 Oct 2015 8:04 pm, "Marcel Greter" notifications@github.com wrote:

I got a positive result with my test runner with that branch!
Wondering why now or put different, why did it not pass before?


Reply to this email directly or view it on GitHub
#647 (comment).

@mgreter
Copy link
Contributor

mgreter commented Oct 15, 2015

Me neither, that's why I posted here, since it seems this is still in todo?
And now I see this is a PR and not an issue ticket (wrong number for todo test?)
Hmm, maybe something was off with my test suite, cannot check right now ...

@xzyfer
Copy link
Contributor Author

xzyfer commented Oct 15, 2015

As far as I can tell this spec (sass/sass-spec#134) as activated 11 months ago.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nth() doesn't handle maps
2 participants