str-slice with $end-at should never return a value #762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xzyfer
force-pushed
the
fix/str-slice-end-at-0
branch
from
8825415 to
dc63805
Compare
1 similar comment
xzyfer
added a commit
that referenced
this pull request
Dec 26, 2014
`str-slice` with `$end-at: `0 should never return a value
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an edge case with
str-slicewhere$start-at == 1and$end-at == 0cause by they're normalisation.Generally speaking
str-sliceshould never return a value when$start-at > $end-at > 0. Our input validation is aware of this, but due to normalisation the case$start-at == 1and$end-at == 0gets normalised to$start-at == 0and$end-at == 0.Essentially we need to enforce
$start-at > $end-at > 0pre-normalisation.Fixes #760. Specs added sass/sass-spec#194.