Skip to content
This repository has been archived by the owner on May 28, 2018. It is now read-only.

Commit

Permalink
Rebuilt linux binaries on debian wheezy
Browse files Browse the repository at this point in the history
  • Loading branch information
andrew committed Nov 19, 2014
1 parent cf66775 commit 9d6417d
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 0 deletions.
Binary file modified linux-ia32/binding.node
100644 → 100755
Binary file not shown.
Binary file modified linux-x64/binding.node
100644 → 100755
Binary file not shown.

13 comments on commit 9d6417d

@ixtli
Copy link

@ixtli ixtli commented on 9d6417d Nov 21, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this commit may have broken installation of node-sass@1.2.3 on ubuntu 12 LTE, tough its entirely possible that I've misconfigured something. I've recorded some digging i've done at sass/node-sass#550 . Let me know if I can help in any other way.

I don't know much about what the output of the libsass is supposed to do (is it an executable binary image, or is it an object file ?) so I'm not sure if i should be able to execute it (chmod +x binding.node && ./binding.node) without getting a segfault.

@am11
Copy link
Contributor

@am11 am11 commented on 9d6417d Nov 21, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it an executable binary image, or is it an object file

Not an object, binding.node is a compiled dynamic / shared binary lib.

@ixtli
Copy link

@ixtli ixtli commented on 9d6417d Nov 21, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, that's kinda what I thought. this line in node-sass calls require on node-sass/vendor/linux-x64/binding.node on my ubuntu box but for some their build script (scripts/build.js) is failing like this:

module.js:355
  Module._extensions[extension](this, filename);
                               ^
Error: Module did not self-register.

@folknor
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same problem for me on Ubuntu 15.04 with npm 2.1.6 and node 0.11.14.

@andrew
Copy link
Contributor Author

@andrew andrew commented on 9d6417d Nov 22, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be noted that node-sass doesn't support v0.11.x yet

@folknor
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How can you tell that it doesn't? I can't find that written anywhere, and package.json says "node": ">=0.10.0".

@am11
Copy link
Contributor

@am11 am11 commented on 9d6417d Nov 22, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vhaarr, because the dependencies we are using have issues with v0.11.x. It isn't stable for 0.11 yet.

@ixtli
Copy link

@ixtli ixtli commented on 9d6417d Nov 22, 2014 via email

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kevva
Copy link
Member

@kevva kevva commented on 9d6417d Nov 22, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't expect everything to work with an unstable version of node.

@folknor
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whomever told you I had any expectations is mistaken. I do not expect anything from free software.

That doesn't mean practices in this project don't need work - this sort of fact could be noted somewhere, some place, in some form. Not that my opinion has any merit or sway or deserves to be listened to.

But, now it is noted, I guess. Here.

@ixtli
Copy link

@ixtli ixtli commented on 9d6417d Nov 22, 2014 via email

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kevva
Copy link
Member

@kevva kevva commented on 9d6417d Nov 22, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Documenting that it doesn't work on an unstable version of node? Why? Thank you for reporting it though :)!

@am11
Copy link
Contributor

@am11 am11 commented on 9d6417d Nov 22, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW, the current stable version of nodejs is: v0.10.33.
Source: http://nodejs.org/.

Please sign in to comment.