Importer returning contents and file no longer retain absolute paths

[gmac]

There is a significant breaking API change in the way imported file contents reference subsequent imports between versions 3.3.3 and 3.4.0.

In v3.3.3, absolute file references provided with imported contents would be passed along for resolving subsequent imports. Example behavior in v3.3.3:

// @import "a"
done({
  file: '/Users/me/sass/lib/a.scss',
  contents: '@import "b"'
});

Next importer call for @import "b":

function(uri, previousUri, done) {
   // uri: "b",
   // previousUri: "/Users/me/sass/lib/a.scss"
}

In v3.4.0, absolute file references are apparently discarded, and only the previous slug is passed along to subsequent importer calls. Example behavior in v3.4.0:

// @import "a"
done({
  file: '/Users/me/sass/lib/a.scss',
  contents: '@import "b"'
});

Next importer call for @import "b":

function(uri, previousUri, done) {
   // uri: "b",
   // previousUri: "a"
}

This is a significant detriment to content importers that rely on the previously resolved content URI for file mapping, and a major enough change that I would have expected it to be part of a major version bump if intentional. If this change is intentional, I'd be curious about the rationale for removing this exceptionally valuable piece of data from the implementation. Without this data, importers now need to maintain a complex external dependency mapping table that can –at best– still only guess upon a previous slug's mapped file.

[mgreter]

I guess https://github.com/sass/node-sass/blob/master/src/binding.cpp#L12 is the culprit, should probably be sass_import_get_imp_path. The names have changed in libsass API and it looks like this got mixed up on the node-sass side. Looks like node-sass could use some more unit tests.

[gmac]

Looks like node-sass could use some more unit tests. 👍

[mgreter]

@gmac I guess their willing to accept Pull Requests in that direction 😉

[gmac]

Noted, and seriously considering.

[xzyfer]

This was fixed in #1220. Will land in v3.4.2.

[Rush]

I am experiencing this problem as well, waiting for release then!

[xzyfer]

I believe this is fixed in v3.4.2. Please open if the issue persists.