-
Notifications
You must be signed in to change notification settings - Fork 1.3k
What is the plan for updating libsass? #233
Comments
|
There has been alot of awesome work in libsass lately, but a chunk of the PS: updating libsass means we need to co-ordinate cutting new binaries for Windows, Linux, and OSX. |
Yeah, I can certainly appreciate wanting to wait for a new release from upstream. We'll try rebuilding the binaries ourselves and using that. It'll get a bit tricky doing it for Linux on our build server and Windows for our dev servers, but hey, somebody's got to do it---and we're the ones in such a rush, not you guys :) |
@domenic which platforms are you using it on? Would you be ok for running on master for a little while? The problem with trying to push new releases when ever libsass updates is that we get their bug reports and lots of unhappy users. |
PS: The binaries live in https://github.com/andrew/node-sass-binaries if you find that it's stable and want to share |
@andrew We're running via a gulp-sass -> node-sass -> libsass on both Windows and Linux. We'd definitely be OK running on master. |
I just tried pulling master from libsass and the tests are all kinds of broken right now 😦 |
When it will update? |
@theaqua we've got some failing tests with master version of libsass, I'm not going to have any time to update it for at least a week right now. |
I may want to spend some time on improving the test but I was trying to run tests on current $ npm run test
> node-sass@0.8.1 pretest /Users/mgol/Documents/projects/public/node-sass
> jshint .
> node-sass@0.8.1 test /Users/mgol/Documents/projects/public/node-sass
> mocha test
․․․․․․․․node(67436,0x7fff77ac0310) malloc: *** error for object 0x10080f8b0: pointer being freed was not allocated
*** set a breakpoint in malloc_error_break to debug
[1] 67433 abort npm run test What could be it? |
Also, I've tried to run test with libsass from master with the following result: $ cd libsass
$ git pull origin master
$ cd ..
$ npm install
...
$ node-gyp rebuild
...
$ npm run test
> node-sass@0.8.1 pretest /Users/mgol/Documents/projects/public/node-sass
> jshint .
> node-sass@0.8.1 test /Users/mgol/Documents/projects/public/node-sass
> mocha test
․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․
29 passing (277ms)
1 failing
1) cli should compile with the --output-style:
actual expected
#navbar {width:80%;height:23px;}#navbar ul {list-style-type:none;}#navbar li {float:left;}#navbar li a {font-weight:bold;}
at EventEmitter.<anonymous> (/Users/mgol/Documents/projects/public/node-sass/test/cli.js:82:14)
at EventEmitter.emit (events.js:106:17)
at /Users/mgol/Documents/projects/public/node-sass/lib/render.js:28:17
at /Users/mgol/Documents/projects/public/node-sass/node_modules/mocha/node_modules/glob/node_modules/graceful-fs/graceful-fs.js:103:5
at Object.oncomplete (fs.js:107:15)
npm ERR! node-sass@0.8.1 test: `mocha test`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the node-sass@0.8.1 test script.
npm ERR! This is most likely a problem with the node-sass package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR! mocha test
npm ERR! You can get their info via:
npm ERR! npm owner ls node-sass
npm ERR! There is likely additional logging output above.
npm ERR! System Darwin 13.0.0
npm ERR! command "node" "/usr/local/bin/npm" "run" "test"
npm ERR! cwd /Users/mgol/Documents/projects/public/node-sass
npm ERR! node -v v0.10.25
npm ERR! npm -v 1.3.25
npm ERR! code ELIFECYCLE
npm ERR!
npm ERR! Additional logging details can be found in:
npm ERR! /Users/mgol/Documents/projects/public/node-sass/npm-debug.log
npm ERR! not ok code 0 Doesn't sound like everything broke and the error is trivial to fix. Am I missing something? |
@mzgol I'm getting a lot more failures than that locally, I've just pushed the latest libsass to master, are you getting the same results with that? |
@andrew The same. EDIT: FWIW, my setup is: OS X 10.9.1, node v0.10.25, npm 1.3.25. |
@mzgol yeah getting the same on travis, so it must be my local setup now. |
@andrew \o/ Does that mean it can be updated after fixing this one test? :) I can submit a PR though it's trivial enough you might want to do it by yourself. |
@andrew You've changed the wrong file. ;) |
Just pushed a fix for that test, we'll need to get binaries updated for mac, linux and windows then we can push a new release. |
👍 Awesome @mzgol, but there are still failing |
@nschonni Ah, OK, I get it. Sure, no rush with the release if it might break someone's code. I'll live on master for now. |
It may be fine, I'm just not sure the best way to test the improvements. PS: I do want this for Bootstrap-sass too 😉 |
What steps are needed to re-build the binaries? I assume just putting I've read https://github.com/andrew/node-sass#rebuilding-binaries but there is no I feel README could be a little improved in this area. ;) EDIT: It seems binaries are generated into the Anyway, @nschonni, you're right about these extend tests. I compared output from original Sass & libsass in our large project and extends are completely messed up. I guess we'll have to wait longer until libsass fixes those errors. |
@mzgol yeah it definitely needs updating, I'll see if I can make some time for it later in the week. |
Let me know when you need the Windows one. |
Any news on this ? |
libsass still has failures in master around the |
oh well, I'll stick with jlong's bootstrap port a little bit longer then since I can't use the official bootstrap port :( |
+1 |
I'm in the middle of moving house at the moment and don't have any free time to work on a new release but if anyone else is interested in pushing it forward I'm happy to give them commit access. |
libsass is down to 2 failing %x {
width: 100px;
%y {
height: 100px;
}
}
.foo {
@extend %x;
.bar { @extend %y }
} |
Hmm, I don't think that case ever worked in LibSass -- I'm not sure how that test got moved out of the to-do folder. Given that |
It was added 4 months ago when libsass was still passing the suite |
Thanks folks for the hard work. I'm keeping an eye on this thread too, as I'm blocked by several issues fixed in the latest libsass, namely: sass/libsass#305 fixed broken scss spritesheets generated by the node spritesmith module. |
👍 Thanks for your hard work. Excited to see this working again...having the same issue as @theaqua mentioned above with |
I've just published v0.8.3 of node-sass which should solve some of these issues, there is still one failing test with |
Hey @andrew - You're awesome. Also, haven't seen you since HybridConf. On Wed, Mar 12, 2014 at 1:56 PM, Andrew Nesbitt notifications@git.luolix.topwrote:
|
Not sure if this is helpful for anyone, but figured I'd post just in case it's useful to someone! I had a very similar error to @mzgol when attempting to run my gulp-sass task:
After some debugging, I figured out that this error was triggered because I had an empty .scss file that I was running through the gulp-sass task. Removing the empty .scss file (or adding text to it) fixed the error. |
Apologies for opening an issue on this, but I couldn't quite find it documented anywhere...
We're trying to move our toolchain over to libsass, but are blocked on sass/libsass#246. That was fixed five days ago, but the changes haven't propagated to node-sass yet: it appears you guys are using a submodule revision that's a month old.
I guess you guys are pegged to the 1.0.1 version from a month ago? Is there any chance of getting a newer bleeding-edge version, or instructions on how to compile such a version?
The text was updated successfully, but these errors were encountered: