Skip to content
This repository has been archived by the owner on Jul 24, 2024. It is now read-only.

node-sass using node-gyp v3.8.0 when v5.0.3 is out is there a reason? #2716

Closed
jasonwilliams opened this issue Jul 29, 2019 · 13 comments
Closed

Comments

@jasonwilliams
Copy link

as title.

node-sass seems to be using an old version of node-gyp (which then pulls in old dependencies), but looks like node-gyp is now on v5.0.3.

Can node-sass bump to this version?

https://github.com/sass/node-sass/blob/master/package.json#L67

@xzyfer
Copy link
Contributor

xzyfer commented Jul 29, 2019

4.0.0 breaks support for old node.

@xzyfer xzyfer closed this as completed Jul 29, 2019
@jeffrson
Copy link

Well, newer node-gyp can use Python3 - which is important when Python2 will be end-of-life at the end of 2019. So you definitely should move on.

@omarlara
Copy link

@xzyfer any plan to upgrade node-gyp 6.0.0? Python2 will be losing support at the end of 2019.

@jkim7
Copy link

jkim7 commented Oct 15, 2019

Yes I'd also like this upgraded, it introduces a file cb-never-called-1.0.1.tgz which throws a malware warning on my antiviruse

@mitchellmebane
Copy link

@xzyfer node-gyp@6.0.1 requires Node >= 6.0.0. Node 4.x has been EOL since April 2018, and Node 5.x has been EOL since June 2018. If you're concerned about strictly following semver, could you please consider cutting a 5.x release with just a node-gyp bump? The Python 2 dependency is going to start being a very big pain point for many users in the coming months.

@LC43
Copy link

LC43 commented Dec 18, 2019

can this be reconsidered?

there's two three vulnerabilities related to old version. Latest node-gyp@6.0.1 uses tar@4.4.12 which clears :

@qnighy
Copy link

qnighy commented Dec 24, 2019

What is blocking this from happening other than compatibility things, which can be addressed by what @mitchellmebane said?

@boggsey
Copy link

boggsey commented Jan 2, 2020

Python 2 is now EOL and the latest versions of node-gyp now support Python 3. Node 8 is also EOL. Would love to see node-sass bump this up.

@kpcyrd
Copy link

kpcyrd commented Feb 3, 2020

Any news here? We're going to drop python2 from Arch Linux in the foreseeable future.

@harrisoncramer
Copy link

I believe the old node-gyp version is breaking installs, for example I've run a clean docker install and this is causing failures, see this thread

@xzyfer
Copy link
Contributor

xzyfer commented Dec 13, 2020

5.0 has been released with latest node-gyp

@saper
Copy link
Member

saper commented Dec 21, 2020

I believe the old node-gyp version is breaking installs, for example I've run a clean docker install and this is causing failures, see this thread

What makes you think so?

@kpcyrd
Copy link

kpcyrd commented Dec 21, 2020

I didn't read the full log in the linked issue but there's:

gyp verb check python checking for Python executable "python2" in the PATH
gyp verb `which` failed Error: not found: python2

so it seems the base image that was used dropped the end-of-life python2 binary.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests