Select a node-gyp versions with python3 support

[cryptomilk]

First time contributor checklist:

• I have read the README and Contributor Guidelines
• I have signed the Contributor Licence Agreement

Contributor checklist:

• My contribution is not related to translations. Please submit translation changes via our Signal Desktop Transifex project.
• My commits are in nice logical chunks with good commit messages
• My changes are rebased on the latest development branch
• A yarn ready run passes successfully (more about tests here)
• My changes are ready to be shipped to users

Description

Select a node-gyp versions with python3 support

See also
sass/node-sass#2841
sass/node-sass#2716

[scottnonnenberg-signal]

Why have different resolutions in both places? Shouldn't both node-gyp resolutions just be 6.1.0?

[cryptomilk]

Ups, fixed.

[scottnonnenberg-signal]

Also, please eliminate the ^ - in our package.json we map to specific versions.

[kpcyrd]

Is there a way to help getting this merged? :)

[scottnonnenberg-signal]

It has a conflict now, but there is something else missing - what's the benefit provided by taking on the risk of these changes?

[kpcyrd]

As an alternative approach, node-sass very recently released its 5.0.0 which doesn't depend on python2 anymore, so modifying dependency resolution is not necessary anymore. :)

[hiqua]

It has a conflict now, but there is something else missing - what's the benefit provided by taking on the risk of these changes?

@scottnonnenberg-signal Is this question answered by the issue linked here? #4783

To elaborate on these: plenty of distributions are in the process of not shipping python2 by default. The next Debian stable (due in the next few months) won't.

node-gyp just dropped support for python2 for its new versions: nodejs/node-gyp#2300

In short, it's not like this change can be avoided. It will have to be done eventually anyway. It might as well be done now that it's still possible to come back on it if something fails unexpectedly and that there's no big rush. It's also an unnecessary barrier to contributions, since people will be increasingly reluctant to install python2 just to contribute minor changes, as @WhyNotHugo has mentioned (e.g. I'm currently trying to build signal-desktop on Debian and I cannot for sure exclude python2/ python3 conflicts for my failing to do so).

[WhyNotHugo]

The lockfile needs updating too. Otherwise, CI just uses the previously locked version: v5.0.3.

[WhyNotHugo]

#4784 works and is ready for review. I'd really appreciate if a dev can look at this soon.

[cryptomilk]

Closing in favor of #4407

[WhyNotHugo]

I think you meant closing in favour of #4784 .