Support for Node 17

[nschonni]

This new major version is supposed to be released on October 19th. Opening this as a placeholder for when we start to get "node-sass won't install" issues.

• Add 17 to CI
• Add the Module version to extensions.js
• Update support table in README.md
• Pick if this should be 6.1 or 7.0, and land any related PRs if we're cutting a major
• Land chore: Drop EOL Node 15 #3122
• Land Set rejectUnauthorized to true by default #3149

/cc @saper @xzyfer

[nschonni]

@xzyfer not sure if we want to try and add #3193 or just the setUnauthorized one

[quisido]

I know this says Node 17 released October 19th, but it wasn't until sometime between Nov 4-10 that GitHub Actions upgraded their Node version for lts/* to 17.x, causing all node-sass dependencies to fail to install.

I'm not sure if this change by GitHub Actions impacts the timelines or priorities of this ticket at all.

EDIT: @nschonni is correct. The change to GitHub Actions was to now use 16.x as lts/* instead of 14.x. The failure for node-sass@5.0.0 is likely expected. React projects should yarn remove node-sass && yarn add --dev sass to resolve the issue.

[nschonni]

Node version for lts/* to 17.x,

No, 17 is not LTS, that is was bumped from 14 to 16 around that date. 17 will never be a LTS release. If that is happening that would be a bug with nvm/GitHub Actions

The work for 17 was mostly done in the other PR, but binaries still need to be cut and an NPM release made.

[xzyfer]

Apologies for the delay I've been job hunting and moving house.

Thanks for this @nschonni. I've merged #3149 and will try to cut a release in the next couple hours.

[xzyfer]

I ran into some issues with the build scripts. Managed to get the windows, osx, linux, and alpine Node 17 binaries uploaded to the v7.0.0 prerelease before going to bed. Will need to copy over the remaining binaries from the v6.0.1 release tomorrow.

[xzyfer]

I ran into some issues with my release script but it's resolved now. V7 has been released with Node 17 support.

[xzyfer]

Version 7.0

…

On Mon, 6 Dec 2021, 11:45 pm RochelleLong, ***@***.***> wrote: What does V7 mean? I’m sorry I’m new to this On Mon, 6 Dec 2021 at 8:13 AM, Michael Mifsud ***@***.***> wrote: > I ran into some issues with my release script but it's resolved now. V7 > has been released with Node 17 support. > > — > You are receiving this because you commented. > Reply to this email directly, view it on GitHub > <#3194 (comment)>, > or unsubscribe > < https://github.com/notifications/unsubscribe-auth/AWYWM5VHILEWVHZ3SC2ZBYDUPSSFZANCNFSM5GCI6EVA > > . > Triage notifications on the go with GitHub Mobile for iOS > < https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 > > or Android > < https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub >. > > -- Rochelle Long. Colossians 3:23 "And whatever you do, do it heartily, as to the Lord and not to men" — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <#3194 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAENSWFSLSVMJ4V6CKCXX3DUPSV6NANCNFSM5GCI6EVA> .