-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Expose config param to allow specific libsass commit for build #389
Comments
I like the sound of that, I prefer the package.json config option myself. |
+1 for package.json |
At present, if end-user wants to get the binary out of the desired libsass and given they have compiler GCC 4.6+ (or VC 2013+) and python v2.7 installed, they can:
Are we aiming to provision automating step 2 here; replacing So user can do: # pwd: node-sass root directory
nano package.json
# updated the value of libsassHash with desired hash, save and close editor, then
node scripts/build --force --update
# where --update would be the new flag which would tell the build script to: git checkout <hash> |
If PKGCONFIG is set to YES in the proces environment, use pkg-config to locate system libsass to be linked. This way there is no need to checkout a src/libsass submodule at all and the library from the package management system can be used. Otherwise fallback to the bundled libsass. By default, use the bundled library. PR: sass#139 PR: sass#389 PR: sass#744
If PKGCONFIG is set to YES in the proces environment, use pkg-config to locate system libsass to be linked. This way there is no need to checkout a src/libsass submodule at all and the library from the package management system can be used. Otherwise fallback to the bundled libsass. By default, use the bundled library. PR: sass#139 PR: sass#389 PR: sass#744
Use environment variables to control how libsass is linked: LIBSASS_EXT variable empty or unset Build a bundled libsass source (from src/libsass). This is the default. LIBSASS_EXT=auto libsass is located using pkg-config and linked dynamically LIBSASS_EXT=yes LIBSASS_CFLAGS= LIBSASS_LDFLAGS= Link libsass manually, by adding compiler flags and linker flags in LIBSASS_CFLAGS and LIBSASS_LDFLAGS, respectively. For example this way libsass can be linked in statically (on Unix): LIBSASS_EXT=yes LIBSASS_CFLAGS=-I/usr/local/include LIBSASS_LDFLAGS=/usr/local/lib/libsass.a When using LIBSASS_EXT there is no need to checkout the libsass source into src/libsass submodule and the library from the package management system can be used. PR: sass#139 PR: sass#389 PR: sass#744
Use environment variables to control how libsass is linked: LIBSASS_EXT variable empty or unset Build a bundled libsass source (from src/libsass). This is the default. LIBSASS_EXT=auto libsass is located using pkg-config and linked dynamically LIBSASS_EXT=yes LIBSASS_CFLAGS= LIBSASS_LDFLAGS= Link libsass manually, by adding compiler flags and linker flags in LIBSASS_CFLAGS and LIBSASS_LDFLAGS, respectively. For example this way libsass can be linked in statically (on Unix): LIBSASS_EXT=yes LIBSASS_CFLAGS=-I/usr/local/include LIBSASS_LDFLAGS=/usr/local/lib/libsass.a When using LIBSASS_EXT there is no need to checkout the libsass source into src/libsass submodule and the library from the package management system can be used. PR: sass#139 PR: sass#389 PR: sass#744
Use environment variables to control how libsass is linked: LIBSASS_EXT variable empty or unset Build a bundled libsass source (from src/libsass). This is the default. LIBSASS_EXT=auto libsass is located using pkg-config and linked dynamically LIBSASS_EXT=yes LIBSASS_CFLAGS= LIBSASS_LDFLAGS= Link libsass manually, by adding compiler flags and linker flags in LIBSASS_CFLAGS and LIBSASS_LDFLAGS, respectively. For example this way libsass can be linked in statically (on Unix): LIBSASS_EXT=yes LIBSASS_CFLAGS=-I/usr/local/include LIBSASS_LDFLAGS=/usr/local/lib/libsass.a When using LIBSASS_EXT there is no need to checkout the libsass source into src/libsass submodule and the library from the package management system can be used. PR: sass#139 PR: sass#389 PR: sass#744
Use environment variables to control how libsass is linked: LIBSASS_EXT variable empty or unset Build a bundled libsass source (from src/libsass). This is the default. LIBSASS_EXT=auto libsass is located using pkg-config and linked dynamically LIBSASS_EXT=yes LIBSASS_CFLAGS= LIBSASS_LDFLAGS= Link libsass manually, by adding compiler flags and linker flags in LIBSASS_CFLAGS and LIBSASS_LDFLAGS, respectively. For example this way libsass can be linked in statically (on Unix): LIBSASS_EXT=yes LIBSASS_CFLAGS=-I/usr/local/include LIBSASS_LDFLAGS=/usr/local/lib/libsass.a When using LIBSASS_EXT there is no need to checkout the libsass source into src/libsass submodule and the library from the package management system can be used. PR: sass#139 PR: sass#389 PR: sass#744
Use environment variables to control how libsass is linked: LIBSASS_EXT variable empty or unset Build a bundled libsass source (from src/libsass). This is the default. LIBSASS_EXT=auto libsass is located using pkg-config and linked dynamically LIBSASS_EXT=yes LIBSASS_CFLAGS= LIBSASS_LDFLAGS= Link libsass manually, by adding compiler flags and linker flags in LIBSASS_CFLAGS and LIBSASS_LDFLAGS, respectively. For example this way libsass can be linked in statically (on Unix): LIBSASS_EXT=yes LIBSASS_CFLAGS=-I/usr/local/include LIBSASS_LDFLAGS=/usr/local/lib/libsass.a When using LIBSASS_EXT there is no need to checkout the libsass source into src/libsass submodule and the library from the package management system can be used. PR: sass#139 PR: sass#389 PR: sass#744
Use environment variables to control how libsass is linked: LIBSASS_EXT variable empty or unset Build a bundled libsass source (from src/libsass). This is the default. LIBSASS_EXT=auto libsass is located using pkg-config and linked dynamically LIBSASS_EXT=yes LIBSASS_CFLAGS= compiler flags LIBSASS_LDFLAGS= linker flags LIBSASS_LIBRARY= library to link Link libsass manually, by adding compiler and linker flags. For example this way libsass can be linked in statically (on Unix): LIBSASS_EXT=yes LIBSASS_CFLAGS=-I/usr/local/include LIBSASS_LIBRARY=/usr/local/lib/libsass.a When using LIBSASS_EXT there is no need to checkout the libsass source into src/libsass submodule and the library from the package management system can be used. PR: sass#139 PR: sass#389 PR: sass#744
Use environment variables to control how libsass is linked: LIBSASS_EXT variable empty or unset Build a bundled libsass source (from src/libsass). This is the default. LIBSASS_EXT=auto libsass is located using pkg-config and linked dynamically LIBSASS_EXT=yes LIBSASS_CFLAGS= compiler flags LIBSASS_LDFLAGS= linker flags LIBSASS_LIBRARY= library to link Link libsass manually, by adding compiler and linker flags. For example this way libsass can be linked in statically (on Unix): LIBSASS_EXT=yes LIBSASS_CFLAGS=-I/usr/local/include LIBSASS_LIBRARY=/usr/local/lib/libsass.a When using LIBSASS_EXT there is no need to checkout the libsass source into src/libsass submodule and the library from the package management system can be used. PR: sass#139 PR: sass#389 PR: sass#744 Conflicts: scripts/build.js
Use environment variables to control how libsass is linked: LIBSASS_EXT variable empty or unset Build a bundled libsass source (from src/libsass). This is the default. LIBSASS_EXT=auto libsass is located using pkg-config and linked dynamically LIBSASS_EXT=yes LIBSASS_CFLAGS= compiler flags LIBSASS_LDFLAGS= linker flags LIBSASS_LIBRARY= library to link Link libsass manually, by adding compiler and linker flags. For example this way libsass can be linked in statically (on Unix): LIBSASS_EXT=yes LIBSASS_CFLAGS=-I/usr/local/include LIBSASS_LIBRARY=/usr/local/lib/libsass.a When using LIBSASS_EXT there is no need to checkout the libsass source into src/libsass submodule and the library from the package management system can be used. PR: sass#139 PR: sass#389 PR: sass#744
Use environment variables to control how libsass is linked: LIBSASS_EXT variable empty or unset Build a bundled libsass source (from src/libsass). This is the default. LIBSASS_EXT=auto libsass is located using pkg-config and linked dynamically LIBSASS_EXT=yes LIBSASS_CFLAGS= compiler flags LIBSASS_LDFLAGS= linker flags LIBSASS_LIBRARY= library to link Link libsass manually, by adding compiler and linker flags. For example this way libsass can be linked in statically (on Unix): LIBSASS_EXT=yes LIBSASS_CFLAGS=-I/usr/local/include LIBSASS_LIBRARY=/usr/local/lib/libsass.a When using LIBSASS_EXT there is no need to checkout the libsass source into src/libsass submodule and the library from the package management system can be used. PR: sass#139 PR: sass#389 PR: sass#744 Conflicts: scripts/build.js
Use environment variables to control how libsass is linked: LIBSASS_EXT variable empty or unset Build a bundled libsass source (from src/libsass). This is the default. LIBSASS_EXT=auto libsass is located using pkg-config and linked dynamically LIBSASS_EXT=yes LIBSASS_CFLAGS= compiler flags LIBSASS_LDFLAGS= linker flags LIBSASS_LIBRARY= library to link Link libsass manually, by adding compiler and linker flags. For example this way libsass can be linked in statically (on Unix): LIBSASS_EXT=yes LIBSASS_CFLAGS=-I/usr/local/include LIBSASS_LIBRARY=/usr/local/lib/libsass.a When using LIBSASS_EXT there is no need to checkout the libsass source into src/libsass submodule and the library from the package management system can be used. PR: sass#139 PR: sass#389 PR: sass#744 Conflicts: binding.gyp scripts/build.js src/sass_context_wrapper.h
I believe this use case has been addressed by the You can now supply the on disk location of the Libsass you wish to use with
|
There are two ways you can specify the external library:
to detect library using or
For example:
|
Although we ship prebuilt binaries, it may be beneficial to allow users to rebuild their own bindings to a specific version of libsass. The use case I'm seeing with this is for those that want the latest libsass, but not require us to re-release and prep for a non-tagged libsass release.
Maybe something like this in the package.config
I lean towards a config value rather than a
.node-sass.yml
, although that would be a valid approach too.@andrew thoughts?
The text was updated successfully, but these errors were encountered: